https://codereview.chromium.org/816053002/diff/40001/test/unittests/compiler/graph-unittest.h
File test/unittests/compiler/graph-unittest.h (right):
https://codereview.chromium.org/816053002/diff/40001/test/unittests/compiler/graph-unittest.h#newcode78
test/unittests/compiler/graph-unittest.h:78:
On 2015/01/15 13:16:16, Benedikt Meurer wrote:
Move these helpers to loop-peeling-unittest.cc. Also they should not
depend on
GraphTest, but rather take a JSGraph.
The plan is to use them in other tests, so maybe another header is more
appropriate, but atm I don't think we are suffering from the too-few
header files problem.
And, they don't really need a JSGraph, just a Graph* and a
CommonOperatorBuilder*, which GraphTest has.
https://codereview.chromium.org/816053002/diff/40001/test/unittests/compiler/graph-unittest.h#newcode80
test/unittests/compiler/graph-unittest.h:80: struct While {
On 2015/01/15 13:16:16, Benedikt Meurer wrote:
According to the style guide "structs should be used for passive
objects that
carry data, and may have associated constants, but lack any
functionality other
than access/setting the data members. The accessing/setting of fields
is done by
directly accessing the fields rather than through method invocations.
Methods
should not provide behavior but should only be used to set up the data
members,
e.g., constructor, destructor, Initialize(), Reset(), Validate().", so
this has
to be class then. See
http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Structs_vs._Classes
I'd prefer to keep these as structs to avoid accessors for all the
members, so that means what? Moving Chain() and Nest() and Phi() to
somewhere else?
https://codereview.chromium.org/816053002/diff/40001/test/unittests/compiler/graph-unittest.h#newcode129
test/unittests/compiler/graph-unittest.h:129: Counter(While& w,
MachineOperatorBuilder* machine, int32_t b, int32_t k)
On 2015/01/15 13:16:16, Benedikt Meurer wrote:
According to the google style guide: All parameters passed by
reference must be
labeled const.
Done.
https://codereview.chromium.org/816053002/diff/40001/test/unittests/compiler/graph-unittest.h#newcode134
test/unittests/compiler/graph-unittest.h:134: Counter(While& w,
MachineOperatorBuilder* machine, Node* b, Node* k)
On 2015/01/15 13:16:16, Benedikt Meurer wrote:
According to the google style guide: All parameters passed by
reference must be
labeled const.
Done.
https://codereview.chromium.org/816053002/diff/40001/test/unittests/compiler/graph-unittest.h#newcode139
test/unittests/compiler/graph-unittest.h:139: void Build(While& w,
MachineOperatorBuilder* machine) {
On 2015/01/15 13:16:16, Benedikt Meurer wrote:
According to the google style guide: All parameters passed by
reference must be
labeled const.
Done.
https://codereview.chromium.org/816053002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
