Thanks. Next bunch of comments.
https://codereview.chromium.org/816053002/diff/40001/test/unittests/compiler/graph-unittest.h
File test/unittests/compiler/graph-unittest.h (right):
https://codereview.chromium.org/816053002/diff/40001/test/unittests/compiler/graph-unittest.h#newcode78
test/unittests/compiler/graph-unittest.h:78:
Thanks. Now you can undo the changes to graph-unittest.h as they're no
longer needed.
https://codereview.chromium.org/816053002/diff/100001/src/compiler/common-operator.h
File src/compiler/common-operator.h (right):
https://codereview.chromium.org/816053002/diff/100001/src/compiler/common-operator.h#newcode59
src/compiler/common-operator.h:59: const Operator*
ResizeMergeOperator(const Operator* const);
Dead method?
https://codereview.chromium.org/816053002/diff/100001/src/compiler/common-operator.h#newcode206
src/compiler/common-operator.h:206: const Operator*
ResizeMergeOrPhi(const Operator* op, int size);
Can you move this into loop-peeling.cc? I don't think there will be any
uses outside of that, and it's not really something that the builder
should be concerned with.
https://codereview.chromium.org/816053002/diff/100001/src/compiler/loop-analysis.cc
File src/compiler/loop-analysis.cc (right):
https://codereview.chromium.org/816053002/diff/100001/src/compiler/loop-analysis.cc#newcode1
src/compiler/loop-analysis.cc:1: // Copyright 2014 the V8 project
authors. All rights reserved.
2015 :-)
https://codereview.chromium.org/816053002/diff/100001/src/compiler/loop-peeling.cc
File src/compiler/loop-peeling.cc (right):
https://codereview.chromium.org/816053002/diff/100001/src/compiler/loop-peeling.cc#newcode69
src/compiler/loop-peeling.cc:69: PeeledIterationImpl* impl =
static_cast<PeeledIterationImpl*>(this);
How about avoiding the PeeledIterationImpl and just put the NodeVector
into the PeeledIteration class itself?
https://codereview.chromium.org/816053002/diff/100001/src/flag-definitions.h
File src/flag-definitions.h (right):
https://codereview.chromium.org/816053002/diff/100001/src/flag-definitions.h#newcode417
src/flag-definitions.h:417: DEFINE_BOOL(stress_loop_peeling, false,
"stress loop peeling optimization")
I'd prefer if all turbofan related flags have "turbo" in their name.
Makes it easier to spot them.
https://codereview.chromium.org/816053002/diff/100001/test/unittests/compiler/graph-unittest.h
File test/unittests/compiler/graph-unittest.h (left):
https://codereview.chromium.org/816053002/diff/100001/test/unittests/compiler/graph-unittest.h#oldcode34
test/unittests/compiler/graph-unittest.h:34: protected:
Reinsert the protected.
https://codereview.chromium.org/816053002/diff/100001/test/unittests/compiler/graph-unittest.h#oldcode67
test/unittests/compiler/graph-unittest.h:67: protected:
Reinsert the protected.
https://codereview.chromium.org/816053002/diff/100001/test/unittests/compiler/graph-unittest.h
File test/unittests/compiler/graph-unittest.h (right):
https://codereview.chromium.org/816053002/diff/100001/test/unittests/compiler/graph-unittest.h#newcode10
test/unittests/compiler/graph-unittest.h:10: #include
"src/compiler/machine-operator.h"
Remove these two includes again.
https://codereview.chromium.org/816053002/diff/100001/test/unittests/compiler/loop-peeling-unittest.cc
File test/unittests/compiler/loop-peeling-unittest.cc (right):
https://codereview.chromium.org/816053002/diff/100001/test/unittests/compiler/loop-peeling-unittest.cc#newcode9
test/unittests/compiler/loop-peeling-unittest.cc:9: #include
"src/compiler/js-operator.h"
This include seems unnecessary.
https://codereview.chromium.org/816053002/diff/100001/test/unittests/compiler/loop-peeling-unittest.cc#newcode10
test/unittests/compiler/loop-peeling-unittest.cc:10: #include
"src/compiler/js-typed-lowering.h"
This include seems unnecessary.
https://codereview.chromium.org/816053002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
