LGTM with CommonOperatorBuilder::ResizeMergeOrPhi() concern remaining.
https://codereview.chromium.org/816053002/diff/100001/src/compiler/common-operator.h
File src/compiler/common-operator.h (right):
https://codereview.chromium.org/816053002/diff/100001/src/compiler/common-operator.h#newcode206
src/compiler/common-operator.h:206: const Operator*
ResizeMergeOrPhi(const Operator* op, int size);
That may introduce another use for that, in which case we can hoist it
into the builder. But please no premature generalization at this point,
so please move it to loop-peeling.cc for now.
https://codereview.chromium.org/816053002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
