https://codereview.chromium.org/947683002/diff/140001/src/harmony-templates.js
File src/harmony-templates.js (right):
https://codereview.chromium.org/947683002/diff/140001/src/harmony-templates.js#newcode24
src/harmony-templates.js:24: var obj = %_CallFunction(callSiteCache,
hash, $MapGet);
On 2015/03/25 16:14:24, adamk wrote:
On 2015/03/25 16:13:36, adamk wrote:
> On 2015/03/25 15:46:24, caitp wrote:
> > On 2015/03/25 15:43:06, adamk wrote:
> > > On 2015/03/25 12:56:27, caitp wrote:
> > > > Couldn't we just call MapGet() (and others) directly here?
> > >
> > > MapGet is now inside a closure, so it's not visible here.
> >
> > I mean, you have a reference to $MapGet, otherwise
%_CallFunction() wouldn't
> > work either.
>
> Not sure what you're saying. I could have called "$MapGet" "MapGet"
instead,
but
> $MapGet seemed a little clearer to me.
Or are you asking about the use of %_CallFunction()? That's necessary
because
MapGet expects its first argument to be in |this|.
OH --- derp, you're right. Course, this map here is private, so $MapGet
could be assigned to the map instance --- anyway, do it how you want to
do it
https://codereview.chromium.org/947683002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
