https://codereview.chromium.org/947683002/diff/140001/src/collection.js
File src/collection.js (right):
https://codereview.chromium.org/947683002/diff/140001/src/collection.js#newcode21
src/collection.js:21: "use strict";
On 2015/03/30 18:55:22, arv wrote:
This extra use strict is not need (it also does no harm)
Isn't this in fact the only one that _does_ have an effect? I thought we
concatenated all the bits of builtin JS together and so the "use strict"
at the top of each file was a lie.
https://codereview.chromium.org/947683002/diff/140001/src/collection.js#newcode58
src/collection.js:58: if (keyIsNaN && IS_NUMBER(candidate) &&
NUMBER_IS_NAN(candidate)) {
On 2015/03/30 18:55:22, arv wrote:
IS_NUMBER(x) && NUMBER_IS_NAN(x)
is repeated in a few places. Maybe we can introduce a new macro for
this?
Happy to do that in a followup, these aren't the only places where this
shows up.
https://codereview.chromium.org/947683002/diff/140001/src/collection.js#newcode88
src/collection.js:88: return (field >>> 2 /* Name::kHashShift */);
On 2015/03/30 18:55:22, arv wrote:
skip parens here
Done.
https://codereview.chromium.org/947683002/diff/140001/src/collection.js#newcode128
src/collection.js:128: if (IS_NUMBER(key) && key === 0) {
On 2015/03/30 18:55:22, arv wrote:
This needs a comment and preferably a bug number.
Removed this in the latest version, the perf differences (now?) seem to
be in the noise. It's possible this causes a mostly-harmless deopt when
running the benchmark.
https://codereview.chromium.org/947683002/diff/140001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/947683002/diff/140001/src/hydrogen.cc#newcode12042
src/hydrogen.cc:12042: HInstruction* result = New<HLoadKeyed>(object,
index, nullptr, FAST_ELEMENTS);
On 2015/03/30 18:55:22, arv wrote:
On 2015/03/30 18:44:54, adamk wrote:
> On 2015/03/30 12:55:42, Toon Verwaest wrote:
> > Seems like it would be more honest to FAST_HOLEY_ELEMENTS and
> ALLOW_RETURN_HOLE
>
> Done.
Would that impact the performance?
I don't believe so, but if it does, that's because it's needed for
correctness (this instruction will now return true for
RequiresHoleCheck()).
https://codereview.chromium.org/947683002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
