LGTM
Sorry for the long delay, I've been a bit swamped.
https://codereview.chromium.org/947683002/diff/140001/src/collection.js
File src/collection.js (right):
https://codereview.chromium.org/947683002/diff/140001/src/collection.js#newcode128
src/collection.js:128: if (IS_NUMBER(key) && key === 0) {
On 2015/03/25 11:17:01, arv wrote:
Is this a bug in crankshaft?
Why is this necessary?
https://codereview.chromium.org/947683002/diff/140001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/947683002/diff/140001/src/hydrogen.cc#newcode12042
src/hydrogen.cc:12042: HInstruction* result = New<HLoadKeyed>(object,
index, nullptr, FAST_ELEMENTS);
Seems like it would be more honest to FAST_HOLEY_ELEMENTS and
ALLOW_RETURN_HOLE
https://codereview.chromium.org/947683002/diff/140001/src/hydrogen.cc#newcode12056
src/hydrogen.cc:12056: Add<HStoreKeyed>(object, index, value,
FAST_ELEMENTS);
FAST_HOLEY_ELEMENTS?
https://codereview.chromium.org/947683002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
