LGTM modulo nits
https://codereview.chromium.org/1092353002/diff/280001/src/ic/ic.cc
File src/ic/ic.cc (right):
https://codereview.chromium.org/1092353002/diff/280001/src/ic/ic.cc#newcode2811
src/ic/ic.cc:2811: switch (op) {
Nit: to compress a little, can you put the returns on the same line as
the cases? Also, put the defaults last.
https://codereview.chromium.org/1092353002/diff/280001/test/unittests/compiler/js-operator-unittest.cc
File test/unittests/compiler/js-operator-unittest.cc (right):
https://codereview.chromium.org/1092353002/diff/280001/test/unittests/compiler/js-operator-unittest.cc#newcode25
test/unittests/compiler/js-operator-unittest.cc:25: struct
OperatorParams {
You should probably rename this back to SharedOperator now.
https://codereview.chromium.org/1092353002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
