LGTMSince `git cl format` does not check JavaScript I used the arv linter instead.
https://codereview.chromium.org/1092353002/diff/340001/src/ic/ic-state.h File src/ic/ic-state.h (right): https://codereview.chromium.org/1092353002/diff/340001/src/ic/ic-state.h#newcode151 src/ic/ic-state.h:151: class StrongField : public BitField<bool, 10, 1> {}; We should update these to use kNext when we make changes to them. https://codereview.chromium.org/1092353002/diff/340001/src/ic/ic.cc File src/ic/ic.cc (right): https://codereview.chromium.org/1092353002/diff/340001/src/ic/ic.cc#newcode2810 src/ic/ic.cc:2810: if (is_strong(language_mode)) { Why is this needed? The two branches looks identical to me. https://codereview.chromium.org/1092353002/diff/340001/test/mjsunit/strong/implicit-conversions.js File test/mjsunit/strong/implicit-conversions.js (right): https://codereview.chromium.org/1092353002/diff/340001/test/mjsunit/strong/implicit-conversions.js#newcode11 test/mjsunit/strong/implicit-conversions.js:11: "-", Array and Object literals should be indented 2 spaces and not 4. https://google-styleguide.googlecode.com/svn/trunk/javascriptguide.xml?showone=Code_formatting#Code_formatting https://codereview.chromium.org/1092353002/diff/340001/test/mjsunit/strong/implicit-conversions.js#newcode11 test/mjsunit/strong/implicit-conversions.js:11: "-", Don't mix ' and " in the same file. ' is preferred: https://google-styleguide.googlecode.com/svn/trunk/javascriptguide.xml?showone=Strings#Strings If you modify an existing file use whatever is in there. https://codereview.chromium.org/1092353002/diff/340001/test/mjsunit/strong/implicit-conversions.js#newcode15 test/mjsunit/strong/implicit-conversions.js:15: ] semicolon https://codereview.chromium.org/1092353002/diff/340001/test/mjsunit/strong/implicit-conversions.js#newcode17 test/mjsunit/strong/implicit-conversions.js:17: let nonnumber_values = [ nonNumberValues https://google-styleguide.googlecode.com/svn/trunk/javascriptguide.xml?showone=Strings#Naming https://codereview.chromium.org/1092353002/diff/340001/test/mjsunit/strong/implicit-conversions.js#newcode51 test/mjsunit/strong/implicit-conversions.js:51: return v; why not just `return x - y`? Is this to prevent inlining? https://codereview.chromium.org/1092353002/diff/340001/test/mjsunit/strong/implicit-conversions.js#newcode109 test/mjsunit/strong/implicit-conversions.js:109: assertThrows("'use strong'; let v = " + expr + ";", TypeError); These things might be easier to read with template literals? https://codereview.chromium.org/1092353002/diff/340001/test/mjsunit/strong/implicit-conversions.js#newcode146 test/mjsunit/strong/implicit-conversions.js:146: } catch(e) { catch (e) Just like if, for etc https://codereview.chromium.org/1092353002/diff/340001/test/mjsunit/strong/implicit-conversions.js#newcode147 test/mjsunit/strong/implicit-conversions.js:147: assertTrue(e instanceof TypeError); or assertInstanceof https://codereview.chromium.org/1092353002/diff/340001/test/unittests/compiler/js-operator-unittest.cc File test/unittests/compiler/js-operator-unittest.cc (right): https://codereview.chromium.org/1092353002/diff/340001/test/unittests/compiler/js-operator-unittest.cc#newcode74 test/unittests/compiler/js-operator-unittest.cc:74: kSharedOperatorsWithlanguageMode[] = { strange indentation https://codereview.chromium.org/1092353002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
