On 2015/05/12 13:51:25, wingo wrote:
Updated patch is pretty much complete modulo a couple of tests. Three
things
aren't working:
1) {} is a valid BindingPattern but not a valid BindingElement. So the
tests
that e.g. ({})=>x is not a valid arrow function fail.
2) Likewise for [].
3) The test that (a=b)=>foo is invalid is now failing, I think because
a=b is
a
valid component of a BindingPattern but I'm not sure.
Any thoughts on these, Dmitry? I guess I can add special cases to {} and
[]
to
make them call ArrowFormalParametersUnexpectedToken.
Actually it seems that [] isn't a valid BindingPattern either. I guess we
should be classifying BindingElement and BindingPattern separately.
https://codereview.chromium.org/1138153003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
