On 2015/05/12 14:13:02, wingo wrote:
On 2015/05/12 14:03:43, wingo wrote:
> On 2015/05/12 14:01:50, caitp wrote:
> > On 2015/05/12 13:51:25, wingo wrote:
> > > Updated patch is pretty much complete modulo a couple of tests.
Three
> things
> > > aren't working:
> > >
> > > 1) {} is a valid BindingPattern but not a valid BindingElement.
So the
> tests
> > > that e.g. ({})=>x is not a valid arrow function fail.
> > >
> >
> > How is it not a valid BindingElement? See 13.2.3.6 for
BindingElement :
> > BindingPattern Initializer[opt]
>
> Good catch caitp, thank you!
So yeah then, I think this patch works fine. The only question is how to
turn
off destructuring to be able to ship these things separately.
ExpressionClassifier does not depend on destructuring flag
https://codereview.chromium.org/1138153003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
