On 2015/05/21 15:10:10, earthdok wrote:
PS#2: The issue is with ICU, which is a C-only target. You put
-fsanitize-memory
in cflags_cc, so it isn't applied to ICU. Thus, even though -fPIC is
implied by
any of -fsanitize={memory,address,thread}, ICU doesn't receive -fPIC.
Takeaways:
- -fsanitize={address,memory,thread} should be in cflags, not cflags_cc.
There's
no reason for C code not to have sanitizer coverage. The same applies to
other
sanitizer-related flags (-fno-omit-frame-pointer, -gline-tables-only).
- the TSan config doesn't need -fPIC and -pie either,
- since you actually have C code in v8 and the distinction between cflags
and
cflags_cc is meaningful, I'd say the proper fix for (PS#1) would be to not
put
-fno-exceptions in cflags in the first place.
https://codereview.chromium.org/1146863006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
