Please take another look
https://codereview.chromium.org/1189743003/diff/1/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/1189743003/diff/1/src/parser.cc#newcode4227
src/parser.cc:4227: descriptor.mode = VAR;
Changing to LET - it is always LET for patterns since it means
IsSimpleParameterList =false
https://codereview.chromium.org/1189743003/diff/1/test/mjsunit/harmony/destructuring.js
File test/mjsunit/harmony/destructuring.js (right):
https://codereview.chromium.org/1189743003/diff/1/test/mjsunit/harmony/destructuring.js#newcode692
test/mjsunit/harmony/destructuring.js:692: (function TestParameters() {
On 2015/06/16 17:02:13, rossberg wrote:
Can we have a few more tests? In particular, including arrow patterns
and nested
patterns?
Also, checks that "function({x}) { var x; }' etc is a syntax error.
Done.
https://codereview.chromium.org/1189743003/diff/1/test/mjsunit/harmony/destructuring.js#newcode699
test/mjsunit/harmony/destructuring.js:699: var g = {a, b} => { return a
- b; };
On 2015/06/16 16:56:36, arv wrote:
This should be a SyntaxError. Only when using a single
BindingIdentifier is the
parens optional.
http://people.mozilla.org/~jorendorff/es6-draft.html#sec-arrow-function-definitions
Remove and file bug.
Done.
https://codereview.chromium.org/1189743003/diff/1/test/mjsunit/harmony/destructuring.js#newcode705
test/mjsunit/harmony/destructuring.js:705: var h = {a, b} => a - b;
On 2015/06/16 17:02:13, rossberg wrote:
AFAICT this is not legal ES6 syntax, see the grammar in
https://people.mozilla.org/~jorendorff/es6-draft.html#sec-arrow-function-definitions
Done.
https://codereview.chromium.org/1189743003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
