LGTM
If you want to handle the property name issue later that is fine with me.
https://codereview.chromium.org/1189743003/diff/60001/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/1189743003/diff/60001/src/parser.cc#newcode2057
src/parser.cc:2057: Expression* expression = NewThrowSyntaxError(
Is there a test for this?
https://codereview.chromium.org/1189743003/diff/60001/src/parser.cc#newcode4301
src/parser.cc:4301:
-1 newline
https://codereview.chromium.org/1189743003/diff/60001/src/parser.h
File src/parser.h (right):
https://codereview.chromium.org/1189743003/diff/60001/src/parser.h#newcode554
src/parser.h:554:
-1 newline
https://codereview.chromium.org/1189743003/diff/60001/src/preparser.h
File src/preparser.h (right):
https://codereview.chromium.org/1189743003/diff/60001/src/preparser.h#newcode2418
src/preparser.h:2418:
classifier->RecordDuplicateFormalParameterError(scanner()->location());
The following is not supposed to be an error.
function f({x: y, x: z}) {}
Can you add a test that this works?
https://codereview.chromium.org/1189743003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
