https://codereview.chromium.org/1312613003/diff/40001/src/full-codegen/full-codegen.cc
File src/full-codegen/full-codegen.cc (right):
https://codereview.chromium.org/1312613003/diff/40001/src/full-codegen/full-codegen.cc#newcode1601
src/full-codegen/full-codegen.cc:1601: DCHECK(var->location() ==
VariableLocation::PARAMETER ||
On 2015/08/25 at 19:13:33, adamk wrote:
Can you move this up above the other one, to keep the logic ordering
the same as before?
Done
https://codereview.chromium.org/1312613003/diff/40001/test/mjsunit/mjsunit.status
File test/mjsunit/mjsunit.status (right):
https://codereview.chromium.org/1312613003/diff/40001/test/mjsunit/mjsunit.status#newcode158
test/mjsunit/mjsunit.status:158: # issue 3926:
On 2015/08/25 at 19:13:33, adamk wrote:
This should be 4388
Done
https://codereview.chromium.org/1312613003/diff/40001/test/mjsunit/regress/regress-3926.js
File test/mjsunit/regress/regress-3926.js (right):
https://codereview.chromium.org/1312613003/diff/40001/test/mjsunit/regress/regress-3926.js#newcode7
test/mjsunit/regress/regress-3926.js:7: // Switch statements should
disable let hole checking
On 2015/08/25 at 19:13:33, adamk wrote:
I think you mean should disable "hole check elimination"
Done
https://codereview.chromium.org/1312613003/diff/40001/test/mjsunit/regress/regress-3926.js#newcode32
test/mjsunit/regress/regress-3926.js:32: { // this block, plus the let
below, adds another lexical scope, this one linear
On 2015/08/25 at 19:13:33, adamk wrote:
Nit: 80 chars
Done
https://codereview.chromium.org/1312613003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
