Just pinging on one of my comments so that it doesn't drown in the noise.
Still
LGTM after that of course.
https://codereview.chromium.org/1312613003/diff/60001/src/full-codegen/full-codegen.cc
File src/full-codegen/full-codegen.cc (right):
https://codereview.chromium.org/1312613003/diff/60001/src/full-codegen/full-codegen.cc#newcode1588
src/full-codegen/full-codegen.cc:1588: bool
FullCodeGenerator::NeedsHoleCheck(VariableProxy* proxy) {
On 2015/08/26 11:30:29, Michael Starzinger wrote:
nit: Can we call this predicate either "NeedsHoleCheckOnLoad" or
"NeedsHoleCheckForLoad", otherwise people might get the idea to use
this for
assignments at some point and become disappointed.
Ping.
https://codereview.chromium.org/1312613003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
