Your reasoning re: ScopeInfo sounds right to me. Can you add a note to
scopes.h
explaining why the bit isn't needed on ScopeInfo?
Also, could you add a few more tests (the ones suggested by Andreas)? In
particular, tests for assignment and loading inside evals (both sloppy and
strict would be good for coverage) and tests for lazy local functions that
assign and load. That'll make sure your comment isn't the only thing keeping
those hole checks in place.
https://codereview.chromium.org/1312613003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
