On 2015/08/31 20:44:10, adamk wrote:
This is looking good to me, will look once more after you've handled the
rest
of
wingo's comments.
I believe these have been addressed in the last patchset
I agree that we should do something nicer with the literals count, it's
quite
messy at the moment and not at all obvious why the count is valid in all
cases.
I don't think this is ever going to be really nice, but it can at least be
unified more, with fewer special cases. Unfortunately, the cover grammars
just
make this more complicated than it was for es5.
I have an idea to fix/unify this, which is to separate literal count
tracking
from FunctionState, and do it on an expression by expression basis. This
should
work, but will be a tiny bit more complicated. I think this should happen
in a
followup or separate CL.
+bmeurer for full-codegen OWNERs (luckily this is mostly deletion).
https://codereview.chromium.org/1272673003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
