LGTM with question and nit.
https://codereview.chromium.org/1272673003/diff/150001/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/1272673003/diff/150001/src/parser.cc#newcode4415
src/parser.cc:4415: // for (var $argument_index = $rest_index;
I guess there was some discussion about this desugaring; so do we have
any plans how to make this work with inlining? esp. inlining in
TurboFan?
https://codereview.chromium.org/1272673003/diff/150001/src/parser.cc#newcode4425
src/parser.cc:4425: auto var = parameters.scope->parameter(i);
Nit: Wow, this heavy autofication. I'm not sure what the convention for
the parser is, but I'd prefer to reduce the use of auto, esp. when it's
used in place of a pointer type.
https://codereview.chromium.org/1272673003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
