http://codereview.chromium.org/1706013/diff/50001/51012 File src/arm/codegen-arm.cc (right):
http://codereview.chromium.org/1706013/diff/50001/51012#newcode8119 src/arm/codegen-arm.cc:8119: // r3: Length of subject string as a SMI On 2010/04/27 11:25:55, Kevin Millikin wrote:
"SMI" ==> "smi". It is not an acronym.
Done. http://codereview.chromium.org/1706013/diff/50001/51012#newcode9032 src/arm/codegen-arm.cc:9032: // Untag SMI. On 2010/04/27 11:25:55, Kevin Millikin wrote:
smi.
Done. http://codereview.chromium.org/1706013/diff/50001/51010 File src/objects-inl.h (right): http://codereview.chromium.org/1706013/diff/50001/51010#newcode1654 src/objects-inl.h:1654: int String::length() { On 2010/04/27 11:25:55, Kevin Millikin wrote:
Why not
SMI_ACCESSORS(String, length, kLengthOffset)
Done. http://codereview.chromium.org/1706013/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
