http://codereview.chromium.org/1706013/diff/65002/41014 File src/arm/codegen-arm.cc (right):
http://codereview.chromium.org/1706013/diff/65002/41014#newcode9144 src/arm/codegen-arm.cc:9144: __ cmp(r2, Operand(0)); // Test if first string is empty. On 2010/04/28 13:33:41, Vyacheslav Egorov wrote:
Comparing smi with non-smi.
Assert kSmiTag == 0 or use Smi::FromInt() ?
Another interesting question [yes I am aware that you are not the
author of the
code] what is faster on ARM tst(x,x) or cmp(x, 0)?
Both take 1 cycle. In the future I suppose that cmp(x, 0) might be faster, since it affects all the flags so there's no false dependency on the previous state of the flags. http://codereview.chromium.org/1706013/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
