http://codereview.chromium.org/1706013/diff/65002/41014 File src/arm/codegen-arm.cc (right):
http://codereview.chromium.org/1706013/diff/65002/41014#newcode8119 src/arm/codegen-arm.cc:8119: // r3: Length of subject string as a smi Missing full stop after comment on these lines. http://codereview.chromium.org/1706013/diff/65002/41014#newcode8122 src/arm/codegen-arm.cc:8122: // Check that the third argument is a positive smi less than the subject we don't actually check that the third argument is a Smi. We just check whether it is in range or not, then shift out the tag bit. Not sure whether that is OK, but the comment should reflect it. http://codereview.chromium.org/1706013/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
