On 2013/09/13 12:16:43, rmcilroy_google wrote:
https://codereview.chromium.org/21063002/diff/68001/src/arm/codegen-arm.cc
File src/arm/codegen-arm.cc (right):
https://codereview.chromium.org/21063002/diff/68001/src/arm/codegen-arm.cc#newcode503
src/arm/codegen-arm.cc:503: r9,
On 2013/09/13 12:06:27, ulan wrote:
> This can clobber r9, so the use below seems to be invalid.
But this is never called on the same codepath as below (L496 never falls
through
since it's an unconditional branch, so the only entry point to
"only_change_map"
is the branch on L443, and the code block immediately branches to "done"
on
L508, so it never hits the use of r9 from L486-L494 and L516-L540).
You're right. There must be a bug somewhere else. I can reproduce the flaky
test
failure when running 5 instances in a loop for ~10 minutes.
https://codereview.chromium.org/21063002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
