https://codereview.chromium.org/21063002/diff/82001/src/arm/codegen-arm.cc
File src/arm/codegen-arm.cc (right):
https://codereview.chromium.org/21063002/diff/82001/src/arm/codegen-arm.cc#newcode484
src/arm/codegen-arm.cc:484: __ ldr(r4, FieldMemOperand(r2,
JSObject::kElementsOffset));
Moving this up to line 454 seems to have fixed the flaky failure.
https://codereview.chromium.org/21063002/diff/82001/src/arm/macro-assembler-arm.cc
File src/arm/macro-assembler-arm.cc (right):
https://codereview.chromium.org/21063002/diff/82001/src/arm/macro-assembler-arm.cc#newcode1344
src/arm/macro-assembler-arm.cc:1344: mov(cp, Operand(Smi::FromInt(0)));
// Indicates no context.
On 2013/09/13 14:14:40, Rodolph Perfetta wrote:
I don't know if this is related to your test flakyness, but here I
don't believe
you can corrupt the context pointer. Look in full-codegen-arm.cc when
PushTryHandler is used
I also had this suspicion, but this case seems to be fine because
PushTryHandler with kind = JS_ENTRY is called only in
JSEntryStub::GenerateBody and cp is later overwrite in
JSEntryTrampoline.
https://codereview.chromium.org/21063002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
