On 2014/02/18 15:40:36, jbramley wrote:
On 2014/02/18 15:39:24, ulan wrote:
> On 2014/02/18 15:33:52, jbramley wrote:
> > On 2014/02/18 15:32:21, jbramley wrote:
> > > I had to modify MakeConvertDToIFuncTrampoline to use PushPopQueue
otherwise
> > its
> > > set of Push calls generated too much code.
> >
> > By the way, was updating this issue the right thing to do in this
situation,
> or
> > should I have created a new one?
>
> It is better to create a new one because this issue is already closed.
Could
you
> please reupload in a new issue?
Yep, no problem.
For future reference, a handy thing to do in this situation is to
upload "patch
set 1" with exactly the same patch set as the reverted CL, then re-upload
your
new CL as "patch set 2". That way reviewers can easily compare "patch set
2"
with "patch set 1" to see only the differences you've made to reland the CL.
https://codereview.chromium.org/169533002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
