On 2014/02/17 16:13:08, ulan wrote:
This broke many debug tests:
#
# Fatal error in ../src/a64/assembler-a64.cc, line 2239
# external code buffer is too small
#

Looks like because of the abort message, we are overflowing the code buffer in
Builtins::SetUp:
union { int force_alignment; byte buffer[16*KB]; } u;

Ok, that makes sense. Can we make that buffer bigger, or do we have to work
within the limit?

Our Aborts are bigger than they need to be at the moment because we encode the whole string rather than just the BailoutReason. (The other architectures work the same; only Throw optimises this to encode just the BailoutReason.) If we fix
that, the code size might reduce enough anyway.

https://codereview.chromium.org/169533002/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to