On 2014/02/17 14:13:10, ulan wrote:
> Do any other V8 team members have an opinion?
I don't have strong opinion on this, but I find A64 version of Pop a bit
easier
to read.
In the following example in A64, the popping order is the same as
the "reading
order":
Pop(a);
Pop(b, c);
Pop(d);
So it is easy to see that we pop a, then b, then c, then d.
In ARM, this example would be:
Pop(a);
Pop(c, b);
Pop(d);
So we need to read top-to-down, right-to-left.
I agree that Push/Pop on ARM and A64 should agree on order of arguments,
otherwise it is confusing.
Ok if the consensus is that this ordering is easier to read I'm fine with
that,
but I definitely think we should move Arm across to the same model to avoid
confusion.
https://codereview.chromium.org/169533002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
