Hello Dirk,
Do you really know what you are doing ? You are not just fixing warnings,
you are changing code. In trunk/coregrind/m_stacktrace.c you changed the
format string %08p into %p. As a result, the printed pointers are no longer
right-aligned. Did you understand what I wrote in the mail I sent on
September 26 to the valgrind-developers mailing list ?
Bart.
On 10/1/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote:
>
> Author: dirk
> Date: 2007-10-01 11:33:41 +0100 (Mon, 01 Oct 2007)
> New Revision: 6928
>
> Log:
> fix a few format string warnings
>
> Modified:
> trunk/coregrind/m_signals.c
> trunk/coregrind/m_stacktrace.c
>
>
> Modified: trunk/coregrind/m_signals.c
> ===================================================================
> --- trunk/coregrind/m_signals.c 2007-10-01 10:21:07 UTC (rev 6927)
> +++ trunk/coregrind/m_signals.c 2007-10-01 10:33:41 UTC (rev 6928)
> @@ -431,7 +431,7 @@
> Int sig;
> VG_(printf)("\n\nSKSS:\n");
> for (sig = 1; sig <= _VKI_NSIG; sig++) {
> - VG_(printf)("sig %d: handler 0x%x, flags 0x%x\n", sig,
> + VG_(printf)("sig %d: handler %p, flags 0x%x\n", sig,
> skss.skss_per_sig[sig].skss_handler,
> skss.skss_per_sig[sig].skss_flags );
>
>
> Modified: trunk/coregrind/m_stacktrace.c
> ===================================================================
> --- trunk/coregrind/m_stacktrace.c 2007-10-01 10:21:07 UTC (rev 6927)
> +++ trunk/coregrind/m_stacktrace.c 2007-10-01 10:33:41 UTC (rev 6928)
> @@ -158,7 +158,7 @@
> fp = (((UWord*)fp)[0]);
> ips[i++] = ip;
> if (debug)
> - VG_(printf)(" ipsF[%d]=%08p\n", i-1, ips[i-1]);
> + VG_(printf)(" ipsF[%d]=%p\n", i-1, ips[i-1]);
> ip = ip - 1;
> continue;
> }
> @@ -168,7 +168,7 @@
> if ( VG_(use_CF_info)( &ip, &sp, &fp, fp_min, fp_max ) ) {
> ips[i++] = ip;
> if (debug)
> - VG_(printf)(" ipsC[%d]=%08p\n", i-1, ips[i-1]);
> + VG_(printf)(" ipsC[%d]=%p\n", i-1, ips[i-1]);
> ip = ip - 1;
> continue;
> }
> @@ -406,7 +406,7 @@
> # endif
>
> if (0)
> - VG_(printf)("tid %d: stack_highest=%p ip=%p sp=%p fp=%p\n",
> + VG_(printf)("tid %d: stack_highest=0x%08lx ip=0x%08lx sp=0x%08lx
> fp=0x%08lx\n",
> tid, stack_highest_word, ip, sp, fp);
>
> return VG_(get_StackTrace2)(tid, ips, n_ips, ip, sp, fp, lr, sp,
>
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Valgrind-developers mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/valgrind-developers
