On 10/3/07, Julian Seward <[EMAIL PROTECTED]> wrote:
>
>
> > I agree with the concerns raised above. But regarding (3): how about the
> > warnings gcc emits on format strings like "%,d", which are supported by
> > Valgrind but which are not allowed by ANSI C ?
>
> I wondered about that too, but at least using gcc 4.1.2 I got no
> complaints
> about "%,d". So it seems ok. Do you have a setup/gcc version in which it
> does complain about "%,d" ?
>
> J
>
The trend with gcc is that new versions move closer to the ANSI standard.
Since the comma is not a valid flag character in ANSI C, we can expect that
a future gcc version will complain about it. Do you think it would be a good
idea to modify the Valgrind source code such that the formatting functions
adhere strictly to the ANSI C standard and to remove extensions like the
insertion of comma's as a thousands separator ? I'm in favor of this -- I
find it confusing that Valgrind's format specifications differ slightly from
those in the C language. Additionally, as far as I know there is currently
no documentation available for Valgrind's format specifications.
For more about format strings, see also paragraph 7.19.6.1 (The fprintf
function) in http://std.dkuug.dk/JTC1/SC22/WG14/www/docs/n843.pdf
Bart.
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Valgrind-developers mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/valgrind-developers
