On Mon, 1 Oct 2007, Bart Van Assche wrote: > Do you really know what you are doing ? You are not just fixing warnings, > you are changing code. In trunk/coregrind/m_stacktrace.c you changed the > format string %08p into %p. As a result, the printed pointers are no longer > right-aligned. Did you understand what I wrote in the mail I sent on > September 26 to the valgrind-developers mailing list ?
I'm wondering what is the right thing to do here. Having the format string warnings is nice, but we should be consistent. Eg. when printing pointers, should we use %p and cast to (void*) when necessary, instead of using 0x%lx? Julian, what do you think? Nick ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ Valgrind-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/valgrind-developers
