On Tue, 24 Mar 2026 17:56:00 GMT, Paul Hübner <[email protected]> wrote:
>> Hi all, >> >> This PR cleans up Valhalla flags. To summarize (for the exhaustive changes, >> please refer to the diff): >> - Many flags have their level bumped down. No product flags remain in >> Valhalla. >> - The granular flattening control flags have received consistent names. >> - Some granular flattening control flags have been experimentalized. >> - Setting granular flattening control flags will give a VM warning is >> flattening is not enabled. >> - Flat array printing has been debugized. >> - Descriptions are updated. >> - Updated all tests to use the new flags. >> >> Testing: tiers 1-3. > > Paul Hübner has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains 17 additional > commits since the last revision: > > - Experimental -> Diagnostic. > - Merge branch 'lworld' into JDK-8379501 > - Fix test failure. > - Experimentalize some flattening flags. > - Diagnosticize compiler flag. > - Adjust level of flattening flags. > - Revert "Rename PrintInlineLayout to PrintValueLayout." > > This reverts commit 382ea88fb72144fce00e51d6fc3274d604b60cd7. > - Revert "Rename InlineTypeX to ValueTypeX." > > This reverts commit 768fd170564bbf24686b4277888ffdb46a5195e8. > - Update src/hotspot/share/runtime/arguments.cpp > > Co-authored-by: Stefan Karlsson <[email protected]> > - Update src/hotspot/share/opto/parse2.cpp > > Co-authored-by: Stefan Karlsson <[email protected]> > - ... and 7 more: > https://git.openjdk.org/valhalla/compare/c8b53b5e...da8b93a6 I have a couple of questions about the whole change. Thanks for making the options diagnostic. ------------- PR Review: https://git.openjdk.org/valhalla/pull/2226#pullrequestreview-4016188909
