On Fri, 20 Mar 2026 09:01:49 GMT, Paul Hübner <[email protected]> wrote:
>> Hi all, >> >> This PR cleans up Valhalla flags. To summarize (for the exhaustive changes, >> please refer to the diff): >> - Many flags have their level bumped down. No product flags remain in >> Valhalla. >> - The granular flattening control flags have received consistent names. >> - Some granular flattening control flags have been experimentalized. >> - Setting granular flattening control flags will give a VM warning is >> flattening is not enabled. >> - Flat array printing has been debugized. >> - Descriptions are updated. >> - Updated all tests to use the new flags. >> >> Testing: tiers 1-3. > > Paul Hübner has updated the pull request incrementally with six additional > commits since the last revision: > > - Fix test failure. > - Experimentalize some flattening flags. > - Diagnosticize compiler flag. > - Adjust level of flattening flags. > - Revert "Rename PrintInlineLayout to PrintValueLayout." > > This reverts commit 382ea88fb72144fce00e51d6fc3274d604b60cd7. > - Revert "Rename InlineTypeX to ValueTypeX." > > This reverts commit 768fd170564bbf24686b4277888ffdb46a5195e8. src/hotspot/share/runtime/globals.hpp line 844: > 842: "Allow the JVM to flatten some null-free atomic values") > \ > 843: > \ > 844: product(bool, UseNullableNonAtomicValueFlattening, true, EXPERIMENTAL, > \ I'd put this flag in the DIAGNOSTIC category instead of EXPERIMENTAL, because it is used for value fields inside value objects (all non-static fields of a value class are strict and final). ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2226#discussion_r2977197341
