On Mon, 6 Apr 2026 21:08:15 GMT, Daniel D. Daugherty <[email protected]> wrote:
>> test/langtools/ProblemList.txt line 89: >> >>> 87: # Valhalla failures start here: >>> 88: >>> 89: # TestValueClasses.java does not live in a valhalla specific directory >>> AND >> >> The comment is not needed, the tests from >> 'valhalla' specific-directory should also problemlisted here. >> The ProblemList-enable-preview.txt is for tests that pass in the default >> mode, but failing with '--enable-preview' jvm args only. Like for any other >> Problemlist-<mode>.txt > > I thought tests in valhalla specific directories would be run via their own > task > definitions where the '--enable-preview' option is specified in the task. All of them have '@enablePreview' to compile and run with enable-preview. The '--enable-preview' works only for tests that doesn't define value classes by themselves. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2303#discussion_r3041718641
