On Mon, 6 Apr 2026 20:50:23 GMT, Daniel D. Daugherty <[email protected]> wrote:
> A trivial fix to move the ProblemList entry for > tools/javac/processing/model/element/TestValueClasses.java to ProblemList.txt. Here's the header comment for the preview section in test/langtools/ProblemList.txt: # Preview project specific failures go here at the end of the file. # # These are NOT failures that occur with the '--enable-preview' option # specified; those go in the appropriate ProblemList-enable-preview.txt file. # These are failures that occur WITHOUT the '--enable-preview' option # specified AND occur because of some issue with preview project code, # in either implementation or test code. That comment was added by this PR: https://github.com/openjdk/valhalla/pull/2007 back at the end of 2026.01 and it was added to all non '*-enable-preview.txt' files. @lmesnik - you were one of my reviewers. This comment that I propose in this PR: # TestValueClasses.java does not live in a valhalla specific directory AND # it specifies the '--enable-preview' option directly instead of via a task # definition so an entry in ProblemList-enable-preview.txt WILL NOT work. is to explain why I'm adding this entry in contradiction to the header comment that was added back at the end of 2026.01. I think a comment of some form is needed here. I'm not attached to the wording that I propose, but we need something here. Now let's look at the flip side of the pair. Here's the '*-enable-preview.txt' comment header block that was added at the end of 2026.01: ############################################################################# # # List of quarantined tests for testing with --enable-preview # # These are failures that ONLY occur with the '--enable-preview' option # specified. There are separate sub-sections for each preview project. # ############################################################################# In https://github.com/openjdk/valhalla/pull/2007, we tried to be really clear that '*-enable-preview.txt' files were for '--enable-preview' failures AND that non '*-enable-preview.txt' files were NOT for '--enable-preview' failures. Now we have a case that shows small cracks in this simple testing architecture distinction that I thought was settled back in 2026.01. We need to clear this up because folks (including me) are gonna get confused. ------------- PR Comment: https://git.openjdk.org/valhalla/pull/2303#issuecomment-4195380546
