On Thu, 9 Apr 2026 13:08:48 GMT, Stefan Karlsson <[email protected]> wrote:
>> src/hotspot/share/oops/markWord.hpp line 156: >> >>> 154: static const uintptr_t null_free_array_bit_in_place = >>> bit_in_place(null_free_array_bits, null_free_array_shift); >>> 155: static const uintptr_t flat_array_bit_in_place = >>> bit_in_place(flat_array_bits, flat_array_shift); >>> 156: static const uintptr_t valhalla_reserved_bit_in_place = >>> bit_in_place(valhalla_reserved_bits, valhalla_reserved_shift); >> >> Nit: alignment. > > Could you clarify what alignment you want me to fix? There's a pre-existing > alignment issue because these names are so long. Fixing that would require > re-aligning all constants in this file. I can do that, but I think it would > be nice to do so as a follow-up. But maybe there was some other alignment > issue you were thinking about. I saw a double space in the vicinity, so I > removed that one. Yeah I meant all constants, because it looks a bit all-over the place. Let's defer it (as a possible starter bug). Thanks for fixing the space. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2310#discussion_r3058229551
