> @caspernorrbin Started cleaning up markWord.hpp with 
> https://github.com/openjdk/valhalla/pull/2238, but while reviewing that patch 
> I realized that it would be good to make a number of simplifications before 
> proceeding. I talked that through with Casper and @Arraying. Those changes 
> have now been done, and I've taken a pass through markWord.hpp to updated the 
> code in the spirit of what Casper did and some of the things we three talked 
> about.
> 
> I've also made updates and clarifications to the comments.
> 
> One main thing about this proposal is that I want it to be crystal clear when 
> we talk about bit and when we talk about a mask. To make sure that the bit 
> constants only ever refers to one bit I've added helpers to verify that this 
> is the case.

Stefan Karlsson has updated the pull request incrementally with one additional 
commit since the last revision:

  Get rid of bit_in_place

-------------

Changes:
  - all: https://git.openjdk.org/valhalla/pull/2310/files
  - new: https://git.openjdk.org/valhalla/pull/2310/files/57458fa1..6857b756

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=valhalla&pr=2310&range=04
 - incr: https://webrevs.openjdk.org/?repo=valhalla&pr=2310&range=03-04

  Stats: 26 lines in 1 file changed: 7 ins; 8 del; 11 mod
  Patch: https://git.openjdk.org/valhalla/pull/2310.diff
  Fetch: git fetch https://git.openjdk.org/valhalla.git pull/2310/head:pull/2310

PR: https://git.openjdk.org/valhalla/pull/2310

Reply via email to