On Fri, 24 Apr 2026 03:30:17 GMT, Serguei Spitsyn <[email protected]> wrote:
> This enhancement is to a add JVMTI debugging support for value object > construction. > The fix includes: > - Minor `GetLocalObject` and `GetLocalInstance` spec clarifications > - JVMTI functions `GetLocalObject` and `GetLocalInstance` now return a > snapshot of the `THIS` object if it is requested during a value object > construction. > - This update adds new test with a needed test coverage: > `test/hotspot/jtreg/serviceability/jvmti/valhalla/GetCtorLocal`. > - Some corrections in the test > `test/hotspot/jtreg/serviceability/jvmti/valhalla/GetSetLocal` for > unification with the test above. > > Testing: > - Tested locally with new test `GetCtorLocal` > - Tested with mach5 tiers 1-6 > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). I think you still need to update com/sun/jdi/valhalla/CtorDebuggingTest.java. I'm seeing the following two asserts fail: // and later we get the same oop (although it's content is changing). assertEquals(breakpointHandler.thisAtBreakpoint(bkpt1), breakpointHandler.thisAtBreakpoint(bkpt2)); assertEquals(breakpointHandler.thisAtBreakpoint(bkpt2), breakpointHandler.thisAtBreakpoint(bkpt3)); I think after your changes the assumption now is that they should not be equal. ------------- PR Review: https://git.openjdk.org/valhalla/pull/2363#pullrequestreview-4173713371
