On Fri, 24 Apr 2026 21:53:04 GMT, Chris Plummer <[email protected]> wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one >> additional commit since the last revision: >> >> review: fixed minor typo > > test/hotspot/jtreg/serviceability/jvmti/valhalla/GetSetLocal/libValueGetSetLocal.cpp > line 35: > >> 33: >> 34: static jvmtiEnv *jvmti = nullptr; >> 35: static jobject cached_this = nullptr; > > I don't think this is used. Thanks, removed. > test/lib/jdk/test/lib/jvmti/jvmti_common.hpp line 287: > >> 285: jlocation loc; >> 286: jvmtiError err = jvmti->GetFrameLocation(thread, depth, &method, >> &loc); >> 287: check_jvmti_status(jni, err, "notifyFramePop: Failed in JVMTI >> GetFrameLocation"); > > The error message needs updating. Updated, thanks. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2363#discussion_r3151065401 PR Review Comment: https://git.openjdk.org/valhalla/pull/2363#discussion_r3151066654
