On Fri, 24 Apr 2026 22:16:20 GMT, Chris Plummer <[email protected]> wrote:
> I think you still need to update com/sun/jdi/valhalla/CtorDebuggingTest.java.
> I'm seeing the following two asserts fail:
Good catch. It seems that I've prepared these changes but lost on my way.
> test/hotspot/jtreg/serviceability/jvmti/valhalla/GetCtorLocal/libValueGetCtorLocal.cpp
> line 113:
>
>> 111: cached_this = jni->NewGlobalRef(obj_this);
>> 112: } else {
>> 113: // cached_this must be a snapshot that not mutate with the ctor
>> changes
>
> Suggestion:
>
> // cached_this must be a snapshot that does not mutate when the ctor
> changes field values
Thanks. Fixed now.
-------------
PR Comment: https://git.openjdk.org/valhalla/pull/2363#issuecomment-4331768989
PR Review Comment:
https://git.openjdk.org/valhalla/pull/2363#discussion_r3151111984
