On Wed, 29 Apr 2026 04:58:16 GMT, Chris Plummer <[email protected]> wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one >> additional commit since the last revision: >> >> review: minor indentation fix > > src/hotspot/share/prims/jvmti.xml line 5893: > >> 5891: If the frame's method is a value object constructor and >> 5892: the requested local is the "<code>this</code>" object, >> the >> 5893: value_ptr is set to a snapshot of the >> "<code>this</code>" object. > > One thing I just realized is that all our spec updates are going to have to > clarify that they are for when in preview mode. I'm not too sure what the > best approach and wording for this is. I think it is ok for you to push this > PR as-is and we can take care of the spec cleanup later. Agreed. It is not clear yet how to make a spec clarification just for preview release. Yes, we can take care of this later. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2363#discussion_r3159532577
