On Wed, 29 Apr 2026 20:21:45 GMT, Dean Long <[email protected]> wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one >> additional commit since the last revision: >> >> review: minor indentation fix > > src/hotspot/share/prims/jvmti.xml line 5893: > >> 5891: If the frame's method is a value object constructor and >> 5892: the requested local is the "<code>this</code>" object, >> the >> 5893: value_ptr is set to a snapshot of the >> "<code>this</code>" object. > > Would it be clearer to say "the value_ptr is set to a copy of the this object > containing a snapshot of the current contents"? I agree, and I was actually planning on using language like this in the JDI and JDWP specs. I was thinking "current state", but "current contents" works also. In any case, we don't need to resolve the spec wording now. Just agree on the concept and the implementation. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2363#discussion_r3164180494
