On Wed, 29 Apr 2026 03:57:50 GMT, Serguei Spitsyn <[email protected]> wrote:
>> This enhancement is to a add JVMTI debugging support for value object >> construction. >> The fix includes: >> - Minor `GetLocalObject` and `GetLocalInstance` spec clarifications >> - JVMTI functions `GetLocalObject` and `GetLocalInstance` now return a >> snapshot of the `THIS` object if it is requested during a value object >> construction. >> - This update adds new test with a needed test coverage: >> `test/hotspot/jtreg/serviceability/jvmti/valhalla/GetCtorLocal`. >> - Some corrections in the test >> `test/hotspot/jtreg/serviceability/jvmti/valhalla/GetSetLocal` for >> unification with the test above. >> >> Testing: >> - Tested locally with new test `GetCtorLocal` >> - Tested with mach5 tiers 1-6 >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Serguei Spitsyn has updated the pull request incrementally with one > additional commit since the last revision: > > review: minor indentation fix src/hotspot/share/prims/jvmti.xml line 5893: > 5891: If the frame's method is a value object constructor and > 5892: the requested local is the "<code>this</code>" object, the > 5893: value_ptr is set to a snapshot of the "<code>this</code>" > object. Would it be clearer to say "the value_ptr is set to a copy of the this object containing a snapshot of the current contents"? ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2363#discussion_r3163933275
