On Wed, 29 Apr 2026 18:12:24 GMT, Quan Anh Mai <[email protected]> wrote:
> Hi, > > This PR redoes [JDK-8377414](https://bugs.openjdk.org/browse/JDK-8377414). > While at it, I encountered > [JDK-8383416](https://bugs.openjdk.org/browse/JDK-8383416) when a > `CastPPNode` is pushed through an unbuffered `InlineTypeNode`, which results > in the oop input being `top`. This incorrectly kills the graph. I tried > fixing JDK-8383416 alone but I encountered the issue with acmp expansion > passing the incorrect base to `InlineTypeNode::check_substitutability`. As a > result, this PR aims at fixing both issues. > > It is easier reviewing each commit. The first one just reverts the backout > PR, the second one ensures that the expansion does not modify the memory, and > the third commit fixes JDK-8383416. > > Testing: > > - [x] tier1-4,valhalla-comp-stress > > Please take a look and leave your review, thanks a lot. > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). Having reviewed [JDK-8377414](https://bugs.openjdk.org/browse/JDK-8377414) already originally, I had a look at the incremental commits and the changes look good to me! test/hotspot/jtreg/compiler/valhalla/inlinetypes/TestLWorld.java line 5238: > 5236: > 5237: @Test > 5238: @IR(failOn = {STATIC_CALL_OF_METHOD, "isSubstitutable.*", ALLOC}) Indentation is off here. ------------- Marked as reviewed by thartmann (Committer). PR Review: https://git.openjdk.org/valhalla/pull/2376#pullrequestreview-4205153199 PR Review Comment: https://git.openjdk.org/valhalla/pull/2376#discussion_r3167956248
