On Tue, 5 May 2026 02:41:41 GMT, Quan Anh Mai <[email protected]> wrote:
>> Hi, >> >> This PR redoes [JDK-8377414](https://bugs.openjdk.org/browse/JDK-8377414). >> While at it, I encountered >> [JDK-8383416](https://bugs.openjdk.org/browse/JDK-8383416) when a >> `CastPPNode` is pushed through an unbuffered `InlineTypeNode`, which results >> in the oop input being `top`. This incorrectly kills the graph. I tried >> fixing JDK-8383416 alone but I encountered the issue with acmp expansion >> passing the incorrect base to `InlineTypeNode::check_substitutability`. As a >> result, this PR aims at fixing both issues. >> >> It is easier reviewing each commit. The first one just reverts the backout >> PR, the second one ensures that the expansion does not modify the memory, >> and the third commit fixes JDK-8383416. >> >> Testing: >> >> - [x] tier1-4,valhalla-comp-stress >> >> Please take a look and leave your review, thanks a lot. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Quan Anh Mai has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains five additional > commits since the last revision: > > - rework expansion precheck > - Merge branch 'lworld' into acmp > - Only push a Cast through an InlineTypeNode if the InlineTypeNode is > buffered > - Fix acmp accidentally writes to memory > - Revert "8377680: [lworld] [BACKOUT] Improve acmp expansion" > > This reverts commit 3a1c2b7bf58ea89e8bd2396557294c65c00a2d13. Thanks for the details. Still good. test/hotspot/jtreg/compiler/valhalla/inlinetypes/TestLWorld.java line 5119: > 5117: > 5118: // Same as test178 but with object argument > 5119: @Test(allowNotCompilable = true) // TODO 8378943: reason should be > "failed spill-split-recycle sanity check" I added a comment to JDK-8378943 so we don't lose track of this. ------------- Marked as reviewed by thartmann (Committer). PR Review: https://git.openjdk.org/valhalla/pull/2376#pullrequestreview-4225614277 PR Review Comment: https://git.openjdk.org/valhalla/pull/2376#discussion_r3186325580
