On Wed, 29 Apr 2026 18:12:24 GMT, Quan Anh Mai <[email protected]> wrote:
> Hi, > > This PR redoes [JDK-8377414](https://bugs.openjdk.org/browse/JDK-8377414). > While at it, I encountered > [JDK-8383416](https://bugs.openjdk.org/browse/JDK-8383416) when a > `CastPPNode` is pushed through an unbuffered `InlineTypeNode`, which results > in the oop input being `top`. This incorrectly kills the graph. I tried > fixing JDK-8383416 alone but I encountered the issue with acmp expansion > passing the incorrect base to `InlineTypeNode::check_substitutability`. As a > result, this PR aims at fixing both issues. > > It is easier reviewing each commit. The first one just reverts the backout > PR, the second one ensures that the expansion does not modify the memory, and > the third commit fixes JDK-8383416. > > Testing: > > - [x] tier1-4,valhalla-comp-stress > > Please take a look and leave your review, thanks a lot. > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). This pull request has now been integrated. Changeset: 0eef7739 Author: Quan Anh Mai <[email protected]> URL: https://git.openjdk.org/valhalla/commit/0eef773921517c58ca6fdf0af75817dd5081b010 Stats: 691 lines in 9 files changed: 460 ins; 115 del; 116 mod 8381826: [lworld] [REDO] Improve acmp expansion 8383416: [lworld] C2: ConstraintCastNode::Ideal incorrectly pushes the cast through an InlineTypeNode Reviewed-by: thartmann ------------- PR: https://git.openjdk.org/valhalla/pull/2376
