On Mon, 8 Jun 2026 17:05:46 GMT, Alan Bateman <[email protected]> wrote:
> The specification of JVMTI GetClassModifiers needs some TLC. The spec was > carried over from the equivalent function in JVMDI but doesn't really specify > that it works like Class::getModifiers and returns Java language modifiers > and not necessarily the access flags from the class file. The change in > behavior to only set ACC_IDENTITY when the class is an identity class or > array makes it a good time to re-write the spec to align with existing and > future behavior. > > A new test is added to test this function with value classes. The tests are > added to the "newer" serviceability/jvmti tree. There are some older tests > for GetClassModifiers in vmTestbase/nsk suite so there is a bit of an overlap. > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). This looks good. I've posted a couple of nits. test/hotspot/jtreg/serviceability/jvmti/GetClassModifiers/libGetClassModifiers.c line 51: > 49: } > 50: return modifiers; > 51: } A couple of nits: - indent is better to be 2 - converting to .cpp would be good ------------- Marked as reviewed by sspitsyn (Committer). PR Review: https://git.openjdk.org/valhalla/pull/2526#pullrequestreview-4470714752 PR Review Comment: https://git.openjdk.org/valhalla/pull/2526#discussion_r3390757142
