On Thu, 11 Jun 2026 08:44:44 GMT, Alan Bateman <[email protected]> wrote:
>> The specification of JVMTI GetClassModifiers needs some TLC. The spec was >> carried over from the equivalent function in JVMDI but doesn't really >> specify that it works like Class::getModifiers and returns Java language >> modifiers and not necessarily the access flags from the class file. The >> change in behavior to only set ACC_IDENTITY when the class is an identity >> class or array makes it a good time to re-write the spec to align with >> existing and future behavior. >> >> A new test is added to test this function with value classes. The tests are >> added to the "newer" serviceability/jvmti tree. There are some older tests >> for GetClassModifiers in vmTestbase/nsk suite so there is a bit of an >> overlap. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Alan Bateman has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains four additional > commits since the last revision: > > - Change libGetClassModifiers to cpp > - Merge branch 'lworld' into GetClassModifiers > - Tweak wording > - Initial commit @AlanBateman Your change (at version 0f1f85b947e5c3c7cb6c2f88d676561f8f4bf36c) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/valhalla/pull/2526#issuecomment-4679234809
