On Thu, 11 Jun 2026 08:40:55 GMT, Alan Bateman <[email protected]> wrote:
>> test/hotspot/jtreg/serviceability/jvmti/GetClassModifiers/libGetClassModifiers.cpp >> line 51: >> >>> (failed to retrieve contents of file, check the PR for context) >> A couple of nits: >> - indent is better to be 2 >> - converting to .cpp would be good > > Okay, moved it to .cpp. It was a bit of a coin toss initially as the tests in > serviceability/jvmti have both .c and .cpp. Thanks. The plan is to make it consistent, at list in the `serviceability/jvmti` folder. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2526#discussion_r3394777986
