On Thu, 18 Jun 2026 19:00:40 GMT, Dean Long <[email protected]> wrote:
>> It would have to be: >> >> assert(t1->is_known_instance() || t2->is_known_instance(), "known instance >> expected during EA phase"); >> >> There's no guarantee both of them are known instances and that code is >> correct if only one is as, I think, we discussed before. Would you be ok >> with this? > > I'm OK with this, but I think there should be a comment that explains why it > is safe to do the comparison. It works because EA would not assign an > instance id if it was possible for it to alias with any other type, right? I added a comment. Does it look ok to you? ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2489#discussion_r3458635075
