On Tue, 23 Jun 2026 09:51:31 GMT, Roland Westrelin <[email protected]> wrote:
>> The bug is caused by a mismatch in the way `LoadFlat` and `StoreFlat` >> are handled in `ConnectionGraph::find_inst_mem()` and >> `MemNode::optimize_simple_memory_chain()`. Once EA has run a first >> time, found some value array allocations as non escaping, and removed >> their `LoadFlat`/`StoreFlat`, igvn runs and is able to further >> transform the memory subgraph which introduces inconsistencies that >> are then caught the next time EA runs. >> >> The fix tries to make sure `ConnectionGraph::find_inst_mem()` and >> `MemNode::optimize_simple_memory_chain()` handle `LoadFlat` and >> `StoreFlat` similarly. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Roland Westrelin has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains 14 commits: > > - comment > - Merge branch 'lworld' into JDK-8385328 > - Merge branch 'lworld' into JDK-8385328 > - review > - Merge branch 'lworld' into JDK-8385328 > - more > - review > - review > - Merge branch 'lworld' into JDK-8385328 > - more > - ... and 4 more: > https://git.openjdk.org/valhalla/compare/5e32888b...cad66106 Marked as reviewed by dlong (no project role). ------------- PR Review: https://git.openjdk.org/valhalla/pull/2489#pullrequestreview-4555901157
