On Fri, 17 Jul 2026 02:23:25 GMT, Serguei Spitsyn <[email protected]> wrote:

>> This update is for `repo-valhalla` pre-integration. It adds a special intro 
>> section to the `jvmti.xml` with a general clarification related to value 
>> objects. Also, it fixes a couple of small typos.
>> 
>> Testing: N/A
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Serguei Spitsyn has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   review: reconsidered again; small tweak for onject tagging spec

Looks good. One suggested update.

src/hotspot/share/prims/jvmti.xml line 14232:

> 14230:       When preview features are enabled, the Object Free event is only 
> sent for tagged
> 14231:       <externallink id="jni/functions.html#hasidentity">identity 
> objects</externallink>.
> 14232:       <b>The event is not sent for tagged value objects.</b>

Suggestion:

      <b>The event is not sent for tagged value objects because they are kept 
alive while tagged.</b>

To be consistent with earlier change.

-------------

Marked as reviewed by dholmes (Committer).

PR Review: 
https://git.openjdk.org/valhalla/pull/2634#pullrequestreview-4718944016
PR Review Comment: 
https://git.openjdk.org/valhalla/pull/2634#discussion_r3600012863

Reply via email to